🐛 fix: removes omitempty from nodeadm template #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faiq
force-pushed
the
faiq/remove-omitempty-from-nodeadm
branch
from
a3766de to
06c413f
Compare
faiq
changed the title
faiq
force-pushed
the
faiq/remove-omitempty-from-nodeadm
branch
from
d1dcf2c to
347960b
Compare
faiq
force-pushed
the
faiq/remove-omitempty-from-nodeadm
branch
from
347960b to
8216090
Compare
5 tasks
dkoshkin
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
If a user is using
NodeadmConfigTemplatewithClusterClassWe run into a bug where SSA fails if a user is removing all fields of theNodeadmConfigTemplate.Spec.Template.Spec. SSA treats this as a null object. Therefore, we are changing the property field tonullableto avoid this issue.See kubernetes/kubernetes#117447 (comment).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: