[W5.7][F10-2]Liu Xiaohang #446
Conversation
wn
left a comment
wn
left a comment
There was a problem hiding this comment.
Don't add code that you haven't implement. Create an issue instead.
wn
left a comment
wn
left a comment
There was a problem hiding this comment.
Commit message isn't a sentence. Don't end with a period.
| } | ||
|
|
||
| /** | ||
| * Returns an unmodifiable java List view with elements cast as immutable {@link ReadOnlyPerson}s. |
| + "\n" + ViewAllCommand.MESSAGE_USAGE | ||
| + "\n" + HelpCommand.MESSAGE_USAGE | ||
| + "\n" + ExitCommand.MESSAGE_USAGE | ||
| + "\n" + SortCommand.MESSAGE_USAGE |
| public static final String COMMAND_WORD = "sort"; | ||
|
|
||
| public static final String MESSAGE_USAGE = COMMAND_WORD + ": sort people in the address book.\n" | ||
| + "Example: " + COMMAND_WORD; |
| import seedu.addressbook.data.person.UniquePersonList; | ||
| import seedu.addressbook.data.tag.Tag; | ||
|
|
||
| public class SortCommand extends Command{ |
jlks96
left a comment
jlks96
left a comment
There was a problem hiding this comment.
Good job on attempting the LO. You seem to have difficulty implementing the tests for the new sort command. Do approach me if you need any help :)
| } | ||
|
|
||
| /** | ||
| * Constructs a feedback message to summarise an operation that displayed a list of sorted persons. |
There was a problem hiding this comment.
summarize (use American spelling), displays
| * @param personsDisplayed used to generate summary | ||
| * @return summary message for persons displayed | ||
| */ | ||
| public static String getMessageForPersonSortShownSummary(List<? extends ReadOnlyPerson> personsDisplayed) { |
There was a problem hiding this comment.
Hmm... method name is not that intuitive
| * Any changes to the internal list/elements are immediately visible in the returned list. | ||
| */ | ||
| public List<ReadOnlyPerson> sortedListView() { | ||
| //internalList.sort(); <--how to make this line work instead of using Collections.sort()? :( |
There was a problem hiding this comment.
https://docs.oracle.com/javase/8/docs/api/java/util/List.html
You have to pass in a comparator in this case. However, we usually just use Collections.sort/ Arrays.sort
| return new SortCommand(); | ||
|
|
||
| case HelpCommand.COMMAND_WORD: // Fallthrough | ||
|
|
4 participants
Add sort command. Use the idea from the instructions on the CS2103/T website "Add a SortCommand class but make it simply a copy of the the existing ListCommand. Direct the sort command to the new SortCommand."