[W5.7][T12-2]Zhou Zegang #431
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenepeh
approved these changes
Sep 15, 2018
eugenepeh
left a comment
eugenepeh
left a comment
There was a problem hiding this comment.
Good job on completing the activity.
Some comments added. Please close the PR after reading the comments.
| import java.util.Collections; | ||
| import java.util.Iterator; | ||
| import java.util.List; | ||
| import java.util.*; |
There was a problem hiding this comment.
remember to disable intellij auto import wildcard
Why is wild card import bad?
|
|
||
| @Override | ||
| public CommandResult execute() { | ||
| Comparator<? super ReadOnlyPerson> comparator = new Comparator<ReadOnlyPerson>() { |
There was a problem hiding this comment.
Good! another way would be to simplify it to use lambda expression.
| @Test | ||
| public void parse_SortCommand_parsedCorrectly() { | ||
| final String input = "sort"; | ||
| parseAndAssertCommandType(input, SortCommand.class); |
There was a problem hiding this comment.
good, but perhaps you can add a test to verify that your sort command is working properly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add sort command