biome: allow overriding config path #440
Open
+26
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimbatm
reviewed
Nov 27, 2025
| config = l.mkIf cfg.enable { | ||
| settings.formatter.biome.options = | ||
| let | ||
| jsonFile = json.generate "biome.json" cfg.settings; |
Member
There was a problem hiding this comment.
Can you move the switch here, so cfg.validate.enable can also be used with the configPath.
Add an assert so either configPath != null XOR cfg.setting != {} ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently not possible to use plugins because the
extendsattribute is evaluated relative to the configuration file, not the current working directory.The current implementation generates the file and doesn't allow overriding the path, so the configuration file is always located at
/nix/store/.... Consequently, the path to any plugin or other relative path in theextendsattribute will always be incorrect.This PR also introduces support for a more recent version of biome.