Skip to content

Expose smallest subnormal constant and add tests for consts#117

Merged
SwayamInSync merged 1 commit into
numpy:mainfrom
juntyr:finfo-consts
Jul 23, 2025
Merged

Expose smallest subnormal constant and add tests for consts#117
SwayamInSync merged 1 commit into
numpy:mainfrom
juntyr:finfo-consts

Conversation

@juntyr

@juntyr juntyr commented Jul 20, 2025

Copy link
Copy Markdown
Contributor
  • exposes SLEEF_QUAD_DENORM_MIN as smallest_subnormal
  • renames min_value (SLEEF_QUAD_MIN) to smallest_normal (since the name is bound to bite people, past myself included)
  • adds tests for the exposed constants

@juntyr juntyr changed the title Expose smallest subnormal and test consts Expose smallest subnormal constant and add tests for consts Jul 20, 2025

@ngoldbaum ngoldbaum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juntyr

juntyr commented Jul 23, 2025

Copy link
Copy Markdown
Contributor Author

@SwayamInSync I've rebased this PR - it should be ready to go now

@SwayamInSync SwayamInSync merged commit 6b5dbb2 into numpy:main Jul 23, 2025
6 checks passed
@SwayamInSync

Copy link
Copy Markdown
Member

Thanks @juntyr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants