feat(auth): migrate account deletion #3345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref numbersprotocol/pipedream#11 - Replace Pipedream webhook with backend DELETE /auth/users/me/ endpoint - Remove unused email parameter from deleteAccount$() method
There was a problem hiding this comment.
Pull Request Overview
This PR migrates account deletion from using a Pipedream webhook to a direct backend API endpoint. The change replaces the external webhook integration with a standardized REST API call to the backend's /auth/users/me/ endpoint.
- Replaces Pipedream webhook POST request with backend DELETE endpoint
- Removes unused email parameter from the deleteAccount$() method signature
- Cleans up environment variables and secrets related to Pipedream integration
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/shared/dia-backend/auth/dia-backend-auth.service.ts | Updates deleteAccount$() method to use DELETE /auth/users/me/ endpoint and removes email parameter |
| src/app/features/settings/settings.page.ts | Removes email retrieval and passes no parameters to deleteAccount$() |
| set-secret.js | Removes PIPEDREAM_DELETE_CAPTURE_ACCOUNT environment variable |
| .github/workflows/pre-release.yml | Removes PIPEDREAM_DELETE_CAPTURE_ACCOUNT from build environment |
| .github/workflows/firebase-release.yml | Removes PIPEDREAM_DELETE_CAPTURE_ACCOUNT from build environment |
| .github/workflows/build-apks.yml | Removes PIPEDREAM_DELETE_CAPTURE_ACCOUNT from build environment |
- Add maxim-lobanov/setup-xcode@v1 action to all iOS CI jobs - Set xcode-version to '16.4' (latest stable on macOS-15 runners) - Fixes "iOS 18.0 Platform Not Installed" build failures - Ensures predictable iOS SDK environment across workflows - Updated workflows: * build.yml (ios job) * firebase-release.yml (distribute-ios job) * pre-release.yml (build-ios-prod, deploy-app-store jobs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref numbersprotocol/pipedream#11