feat: extract message metadata #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeranYang
reviewed
Jan 29, 2026
| /** | ||
| * Constants for Pulsar message headers and metadata. | ||
| */ | ||
| public class Constants { |
Contributor
There was a problem hiding this comment.
These constants are only used by consumer so let's put them under consumer folder and see if we can change the assessor level so that other pkg cannot access them. When adding a variable or method, make it as private as possible, that way we achieve the best abstraction.
Rename the class from Constants to NumaHeaderKeys which is more close to the real intent.
Comment on lines
269
to
272
| Map<String, String> customProps = new HashMap<>(); | ||
| customProps.put("custom-key-1", "custom-value-1"); | ||
| customProps.put("custom-key-2", "custom-value-2"); | ||
| customProps.put("app-version", "1.2.3"); |
Contributor
There was a problem hiding this comment.
nit: This new test is to verify custom properties still added to the headers. Can we merge it into the existing test case? Less boilerplate code.
Signed-off-by: Cece Ma <[email protected]>
KeranYang
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added method implemented to extract message metadata + junit tests to verify, update numaflow sdk, update springboot version for protobuf compatibility
Tested with streamnative pulsar cluster with consumer pipeline:
mvn clean packagekubectl delete pod cloud-consumer-pipeline-in-0-xn9lhkubectl logs cloud-consumer-pipeline-out-0-1o5xf -c numa --tail=20, as can be seen messages now contain extra headers with pulsar metadatacloses #51