-
Notifications
You must be signed in to change notification settings - Fork 2
Signing Product Bot Updates #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
derekpierre
wants to merge
17
commits into
main
Choose a base branch
from
secreto
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,644
−1,892
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
702ffe1
Relock depdendencies to use `nucypher` secreto branch.
derekpierre f25bf7d
Add the ability to query information about signing cohorts.
derekpierre 32bf1bb
Extract SigningCoordinatorAgent from contract registry.
derekpierre 057daaa
Update `nucypher` dependency to a newer commit.
derekpierre 49f0703
Properly iterate through agents on a per domain basis.
derekpierre f620e6a
Add awaiting conditions status for signing rituals.
derekpierre bffde4c
Relock dependencies to latest `nucypher` `secreto`.
derekpierre a535a21
Update code for providing signing ritual information now that Signing…
derekpierre d344529
Update `nucypher` dependency to be the `signing` epic branch.
derekpierre 229dee2
Fix bug.
derekpierre b2899eb
Update `nucypher` dependency to be the `v7.7.x` epic branch.
derekpierre 0608333
Update contract registry URL template to use signing epic branch in n…
derekpierre 9ca8ce0
Relock dependencies for latest `nucypher` changes.
derekpierre 363ce26
Update base docker image to rust-python so that nucypher-core github …
derekpierre 6e184c3
Merge pull request #9 from derekpierre/updated-signing-infra
derekpierre 80cc4b0
Add updates for tapir signing infra.
derekpierre 8ff73a5
Add updates for mainnet signing infra.
derekpierre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| BASE_URL = 'https://raw.githubusercontent.com/nucypher/nucypher-contracts/main/deployment/artifacts/{domain}.json' | ||
| BASE_URL = 'https://raw.githubusercontent.com/nucypher/nucypher-contracts/signing/deployment/artifacts/{domain}.json' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The color mapping refers to a 'PENDING' state which is not defined in the SigningRitualState enum. Consider either adding a PENDING state to the enum or updating the mapping to use an existing state.