Remove specific arguments from config file before procesing#52
Open
Ian0sborne wants to merge 2 commits intonu-ZOO:mainfrom
Open
Remove specific arguments from config file before procesing#52Ian0sborne wants to merge 2 commits intonu-ZOO:mainfrom
Ian0sborne wants to merge 2 commits intonu-ZOO:mainfrom
Conversation
Ian0sborne
force-pushed
the
improve-config-parameter-extraction
branch
from
ecb076e to
4a98644
Compare
Member
|
I believe you've already made adjustments to this based on discussions we've had in person, so I'll wait for those changes to be committed before beginning the review :) |
jwaiton
requested changes
Feb 15, 2026
Member
jwaiton
left a comment
jwaiton
left a comment
There was a problem hiding this comment.
Other than the import, looks good! I recommend double checking that there are adequate tests for this block of code in MULE (I believe there are). Once these two things are done, I'll be able to approve it.
| @@ -1,3 +1,4 @@ | |||
| from concurrent.futures import process | |||
Member
There was a problem hiding this comment.
I don't believe this import is needed is it? :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving #49, this PR removes
configfile parametersprocessandwavedump_editionexplicitly instead of using array index slicing.This is safer and more future proof for two reasons: