Merge develop branch: Add SRv6 Service Segment support, refactor codebase, and update tools #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motok1
force-pushed
the
develop
branch
10 times, most recently
from
d420884 to
961c1c7
Compare
watal
force-pushed
the
develop
branch
3 times, most recently
from
8c61705 to
008c478
Compare
Motok1
force-pushed
the
develop
branch
2 times, most recently
from
870a252 to
f8b109e
Compare
watal
force-pushed
the
develop
branch
2 times, most recently
from
4f455d0 to
0fa87f9
Compare
Motok1
force-pushed
the
develop
branch
3 times, most recently
from
61ad5ba to
2d87ae1
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This is a major refactoring PR that merges the develop branch into main, introducing SRv6 Service Segment support and comprehensive code modernization. The changes encompass API refactoring with improved naming conventions, enhanced type safety through custom types, dynamic path computation using TED (Traffic Engineering Database), and comprehensive test coverage improvements.
Key changes include:
- Introduction of SRv6 Service Segments with uSID-based dynamic path computation
- Comprehensive API refactoring with improved type safety and consistent naming patterns
- Enhanced error handling and validation throughout the codebase
Reviewed Changes
Copilot reviewed 79 out of 84 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/grpc/go/* | Updated gRPC tool clients to use new API package structure and improved naming conventions |
| test/scenario_test/* | Added comprehensive scenario tests for both SR-MPLS and SRv6 uSID configurations |
| test/*.py | New Python-based testing infrastructure with pytest and containerlab integration |
| pkg/server/*.go | Major refactoring with improved error handling, TED integration, and enhanced session management |
| pkg/packet/pcep/*.go | Complete PCEP packet library overhaul with type-safe enums and comprehensive test coverage |
| internal/pkg/version/version.go | Updated constant naming to follow Go conventions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
watal
force-pushed
the
develop
branch
5 times, most recently
from
8424177 to
2fda103
Compare
…egment validation
…indRouterIDFromAddress
…odeFromBytes validation Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…yclomatic complexity
…cyclomatic complexity
…duce cyclomatic complexity
fix(server): correct validation message for ASN to indicate zero value Co-authored-by: Copilot <[email protected]>
refactor(pcep): extract expected length into variable Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
docs(test): replace fixed timestamp with generic placeholder in example output Co-authored-by: Copilot <[email protected]>
Yuya9786
approved these changes
Nov 28, 2025
Yuya9786
left a comment
Yuya9786
left a comment
There was a problem hiding this comment.
Reviewed the changes and tested following the README steps. Everything worked correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for uSID-based dynamic path computation using TED and SRv6 Service Segments.
Several packages have been refactored to improve naming consistency, error handling, and test coverage.
Specifically, kebab-case in YAML identifiers has been removed (e.g., grpc-client → grpcClient).
Additionally, the Go and protoc versions have been updated, and CI workflows have been improved.
Type of change
How is This Tested?
Testing can be performed using TED scenario tests and dynamic path computation example environments with Containerlab.
Please refer to test/README and examples/containerlab/srv6_usid_dynamic-path for detailed instructions.