fixed ntpdate's exit status #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under Windows the exit status of ntpdate was 0, even if the clock-stepping failed.
alfur
commented
Mar 27, 2018
Author
alfur
left a comment
alfur
left a comment
There was a problem hiding this comment.
looks like the notice was shown if the stepping succeeded, so the new code would change the behaviour :-/
better: if (just_log || !failed)
personally I would appreciate the notice in any case
Author
|
@hstenn Hello :) Any chance to get a review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Windows the exit status of ntpdate was 0, even if the clock-stepping failed (e.g. due to missing rights to adjust the clock)