Skip to content

client: add MaxSearchObjectsCount constant #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2025
Merged

client: add MaxSearchObjectsCount constant #745

merged 1 commit into from
Sep 29, 2025

Conversation

Turalchik
Copy link

No description provided.

@codecov Codecov
Copy link

codecov bot commented Sep 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.75%. Comparing base (dd38fa9) to head (ae01dc6).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
+ Coverage   58.73%   58.75%   +0.01%     
==========================================
  Files         164      164              
  Lines       20638    20638              
==========================================
+ Hits        12122    12126       +4     
+ Misses       8249     8245       -4     
  Partials      267      267

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

roman-khimov
roman-khimov reviewed Sep 29, 2025
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Exported constant must be commented.
  2. It also can be used internally, likely there is some code already requiring it.

@Turalchik Turalchik force-pushed the add-max-search-objects-constant branch from c6ef9e9 to c9443a1 Compare September 29, 2025 13:04
cthulhu-rider
cthulhu-rider reviewed Sep 29, 2025
View reviewed changes
Copy link
Contributor

@cthulhu-rider cthulhu-rider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace literal in option doc too

@Turalchik Turalchik force-pushed the add-max-search-objects-constant branch from c9443a1 to 316bccf Compare September 29, 2025 13:49
@cthulhu-rider
Copy link
Contributor

Replace literal in option doc too

push?

@Turalchik Turalchik force-pushed the add-max-search-objects-constant branch from 316bccf to ae01dc6 Compare September 29, 2025 15:22
@cthulhu-rider cthulhu-rider merged commit 5aeb8b4 into master Sep 29, 2025
10 checks passed
@cthulhu-rider cthulhu-rider deleted the add-max-search-objects-constant branch September 29, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smallhive smallhive smallhive approved these changes

@cthulhu-rider cthulhu-rider cthulhu-rider approved these changes

@carpawell carpawell Awaiting requested review from carpawell carpawell is a code owner

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Turalchik @cthulhu-rider @smallhive @roman-khimov