Skip to content

Conversation

roman-khimov
Copy link
Member

No description provided.

Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 97.18310% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.73%. Comparing base (3c286a4) to head (43606c4).
⚠️ Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
client/status/success.go 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
+ Coverage   58.61%   58.73%   +0.12%     
==========================================
  Files         163      164       +1     
  Lines       20570    20641      +71     
==========================================
+ Hits        12057    12124      +67     
- Misses       8246     8249       +3     
- Partials      267      268       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, docs in SDK sometimes look like a mess to me, but i have just reread this one more time, and it seems that you need to extend some comments to some methods in client package.

It's treated as error to return because only client can figure out if it's
OK to proceed.

Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
@roman-khimov roman-khimov merged commit dd38fa9 into master Sep 26, 2025
10 checks passed
@roman-khimov roman-khimov deleted the api-2.19 branch September 26, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants