-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(js): WIP stop bumping pinned versions when proposed version bump does not satisfy current semver version #31474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
laneysmith
wants to merge
3
commits into
nrwl:master
Choose a base branch
from
laneysmith:laneys/fix-31454-dont-bump-pinned-versions-with-preserveLocalDependencyProtocols
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
View your CI Pipeline Execution ↗ for commit 5ea53e9.
☁️ Nx Cloud last updated this comment at |
laneysmith
commented
Jun 5, 2025
@@ -1332,6 +1332,17 @@ Valid values are: ${validReleaseVersionPrefixes | |||
if (!currentDependencyVersion) { | |||
continue; | |||
} | |||
const targetMatchesRequirement = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapted from this line in release-version/utils/resolve-local-package-dependencies.ts
.
…for fixed versions
6535709
to
db1c04e
Compare
…t satisfy current semver version
db1c04e
to
5ea53e9
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
In the legacy versioning logic, you could use workspace protocol and pinned versions for the same upstream dependency, and bumping the upstream package would only affect downstream projects that depended on it via workspace protocol:
The new versioning logic introduced a regression where the pinned version would be bumped to the latest version of the upstream package. So bumping
@company/upstream
to8.2.0
replaces"@company/upstream": "7.3.4"
with"@company/upstream": "8.2.0"
in@company/downstream-pinned
.Expected Behavior
Bumping
"@company/upstream"
to8.2.0
should only affect"@company/downstream-workspace"
and not"@company/downstream-pinned"
.In our Nx monorepo, we generally adhere to a single version policy, but we have a few exceptions where we need to pin versions during migrations. Given that Nx supports both single version policy and independently maintained dependencies, I'd expect that we could continue to use pinned versions in this scenario.
Related Issue(s)
Fixes # #31454