Update leaflet.heightgraph to fix marker hiding & more#849
Open
tbsmark86 wants to merge 6 commits intonrenner:masterfrom
Open
Update leaflet.heightgraph to fix marker hiding & more#849tbsmark86 wants to merge 6 commits intonrenner:masterfrom
tbsmark86 wants to merge 6 commits intonrenner:masterfrom
Conversation
fixes nrenner#408 and similar bug in the graph itself includes nrenner/Leaflet.Heightgraph#1 to display selection stats
Now hotline and heightgraph will use (almost) the same color
Contributor
Author
|
After diving into the height graph code i played around with it some more and also worked on #361 and maybe #416 - meaning syncing the color on the map with that of the graph. Downside is that is very colorful now because of course real road are rarely steady climbing:
What you guy's are thinking about this? There are further directions we could take this
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

fixes #408 and similar bug in the graph itself
includes nrenner/Leaflet.Heightgraph#1 to display selection stats
Of course there is no need to switch the heightgraph repo to me. If instead you like to pull the changes into your heightgraph repo and let the package.json point there.