-
Notifications
You must be signed in to change notification settings - Fork 31
add support for Babylon mainnet #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes introduce support for the Babylon blockchain node within the system. A new configuration file, Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
data/babylon.ini (1)
1-9: Suggest adding documentation for key semanticsConsider adding inline comments or a section header to describe each property (for example, clarifying the difference between
networkand achain_id) and confirm thatnetwork = "net5"matches the expected Babylon mainnet chain identifier. This will improve readability and maintainability for future contributors.data/chain_registry.ini (1)
358-360: Verify registry ordering and URL accessibilityOptionally, alphabetizing entries in
chain_registry.iniwould aid discoverability. Also run a quick check (curl -I) to ensure the raw URL resolves and that the branch name (main) is correct.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
data/babylon.ini(1 hunks)data/chain_registry.ini(1 hunks)notionalapi/gateway/redeploy_all.sh(1 hunks)
🔇 Additional comments (3)
data/babylon.ini (1)
1-9: Validate new chain configuration entriesThe
data/babylon.inientries align with other chain configs, specifying repository, version, daemon, and pruning strategy. Ensure that the file loader expects these exact keys and that environment variables like$HOMEare expanded properly at runtime.Please verify key names (
minimum_gas_prices,start_flags,snapshot_prune, etc.) against existing.inischemas (e.g.,cosmoshub.ini) to avoid misconfiguration.data/chain_registry.ini (1)
358-360: Approve Babylon registry entryThe
[babylon]block correctly references the newbabylon.inion GitHub, enabling the chain registry to include the Babylon mainnet.notionalapi/gateway/redeploy_all.sh (1)
8-8: Approve inclusion of Babylon in redeploy scriptAdding
babylonto theSERVICESlist is correct and maintains alphabetical order alongsidebabylon-testnet, ensuring the Babylon service will be redeployed automatically.
|
@baabeetaa @hqdNotional Hi there, please have a look in the following PR when you have time, thanks in advance 👍 |
📝Summary:
Babylon mainnetbased on Polkachu🎯Details:
data/babylon.ini- created separateBabylondedicated filedata/chain_registry.ini- addedBabylonurl linknotionalapi/gateway/redeploy_all.sh- addedbabylonline to redeploy scriptSummary by CodeRabbit