Skip to content

Conversation

@afa-farkhod
Copy link

@afa-farkhod afa-farkhod commented May 3, 2025

📝Summary:

  • add support for Babylon mainnet based on Polkachu

🎯Details:

  • data/babylon.ini - created separate Babylon dedicated file
  • data/chain_registry.ini - added Babylon url link
  • notionalapi/gateway/redeploy_all.sh - added babylon line to redeploy script

Summary by CodeRabbit

  • New Features
    • Added configuration support for the Babylon blockchain node, including a dedicated configuration file and chain registry entry.
  • Chores
    • Updated deployment scripts to include the Babylon service in automated redeployment.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 3, 2025

Walkthrough

The changes introduce support for the Babylon blockchain node within the system. A new configuration file, babylon.ini, is added to define parameters for running a Babylon node. The chain registry is updated to include Babylon by referencing its configuration. Additionally, the redeployment script is modified to include Babylon in its list of services, ensuring it is managed alongside other services during redeployment operations. No changes are made to code declarations or exported entities.

Changes

File(s) Change Summary
data/babylon.ini Added new configuration file specifying parameters for Babylon blockchain node operation.
data/chain_registry.ini Added a new entry for Babylon, referencing its configuration URL.
notionalapi/gateway/redeploy_all.sh Included "babylon" in the list of services to be redeployed by the script.

Poem

In the warren of code, a new path appears,
Babylon hops in, greeted with cheers!
Configs are nestled, the registry grows,
Redeploy script learns where the new service goes.
With every new node, our network expands—
A rabbit’s delight, in digital lands!
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
data/babylon.ini (1)

1-9: Suggest adding documentation for key semantics

Consider adding inline comments or a section header to describe each property (for example, clarifying the difference between network and a chain_id) and confirm that network = "net5" matches the expected Babylon mainnet chain identifier. This will improve readability and maintainability for future contributors.

data/chain_registry.ini (1)

358-360: Verify registry ordering and URL accessibility

Optionally, alphabetizing entries in chain_registry.ini would aid discoverability. Also run a quick check (curl -I) to ensure the raw URL resolves and that the branch name (main) is correct.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d9afa85 and 9ad5969.

📒 Files selected for processing (3)
  • data/babylon.ini (1 hunks)
  • data/chain_registry.ini (1 hunks)
  • notionalapi/gateway/redeploy_all.sh (1 hunks)
🔇 Additional comments (3)
data/babylon.ini (1)

1-9: Validate new chain configuration entries

The data/babylon.ini entries align with other chain configs, specifying repository, version, daemon, and pruning strategy. Ensure that the file loader expects these exact keys and that environment variables like $HOME are expanded properly at runtime.

Please verify key names (minimum_gas_prices, start_flags, snapshot_prune, etc.) against existing .ini schemas (e.g., cosmoshub.ini) to avoid misconfiguration.

data/chain_registry.ini (1)

358-360: Approve Babylon registry entry

The [babylon] block correctly references the new babylon.ini on GitHub, enabling the chain registry to include the Babylon mainnet.

notionalapi/gateway/redeploy_all.sh (1)

8-8: Approve inclusion of Babylon in redeploy script

Adding babylon to the SERVICES list is correct and maintains alphabetical order alongside babylon-testnet, ensuring the Babylon service will be redeployed automatically.

@afa-farkhod
Copy link
Author

@baabeetaa @hqdNotional Hi there, please have a look in the following PR when you have time, thanks in advance 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant