Fix stbi_write_bmp invalid bV4CSType header value for 32-bit images - #1975
Open
cpsurfer wants to merge 1 commit into
Open
Fix stbi_write_bmp invalid bV4CSType header value for 32-bit images#1975cpsurfer wants to merge 1 commit into
cpsurfer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When writing 32-bit RGBA images via
stbi_write_bmp, the function utilizes aBITMAPV4HEADERbut assigns0(LCS_CALIBRATED_RGB) to thebV4CSTypefield. Because the subsequent endpoint profiles are also written as zero, strict image parsers—such as Microsoft Paint (pbrush)—fail to validate the header, resulting in a file load error.Solution
This PR changes the
bV4CSTypeparameter from0to0x73524742(LCS_sRGB). This explicitly marks the color space as standard sRGB, ensuring compliance with strict OS-level parsers and fixing the load failures without altering the structural layout or size of the header.I dedicate this modification to the public domain.