FIX: use snprintf instead of sprintf#1619
Closed
ismagilli wants to merge 1 commit into
Closed
Conversation
Author
|
Update commit text: - FIX: use snprintf instead of sprintf
+ FIX: image_writer: use snprintf instead of sprintf |
|
is there a reason this wasn't merged? |
9 tasks
Owner
no (i mean, of course the answer to this specific wording is 'yes' basically by definition, but i know what you mean, and the answer to that is 'no') |
ok, I opened a new PR with a cherry-pick from this branch in #1887 on the chance that this could be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern compilers warn that the
sprintffunction is deprecated. I have added a call tosnprintffunction.Note. Function
snprintfappeared only in C99, so I added a check that the program compiles to the C99 standard and above. Thegccandclangcompilers define the constant__STDC_VERSION__. Thedefined(__STDC_VERSION__)check is necessary because the__STDC_VERSION__constant may not defined.From
man snprintf: