Bug fix: Tree find() didn't look for files deeper than two levels#12
Open
iamwilhelm wants to merge 2 commits intonotatestuser:masterfrom
Open
Bug fix: Tree find() didn't look for files deeper than two levels#12iamwilhelm wants to merge 2 commits intonotatestuser:masterfrom
iamwilhelm wants to merge 2 commits intonotatestuser:masterfrom
Conversation
Owner
|
Yes, please cover with tests |
Author
|
Right, but how did you edit the test fixtures? Or did you want me to create a new text fixture for the test? |
Owner
|
#8 has a recommendation with regard to test fixtures if you didn't catch it. |
notatestuser
force-pushed
the
master
branch
3 times, most recently
from
8b34419 to
ab4de66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The split() function basically truncated everything after two levels. What we needed to do was to get the head and rest of the path components.
I suppose I could use unshift() here, since doing .join() would be O(n) anyway. Let me know if you think that'd be cleaner to do.
Also, I did write tests for it, but I wasn't able to update the test fixtures appropriately to reflect a deeper dir hierarchy. So while the tests pass, none of the test fixtures have something 3 layers deep. Should I add another one?