nostr: support full-range nip44 v2 payloads - #1456
Merged
yukibtc merged 2 commits intoAug 22, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Exercise platform size and allocation error mappings without requiring multi-gigabyte buffers.
yukibtc
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extend the existing NIP-44 v2 encryption and decryption APIs to support the full plaintext range defined by the protocol.
Payloads from 1 through 65,535 bytes retain the existing two-byte big-endian length prefix. Larger payloads use the extended
00 00marker followed by a four-byte big-endian length. Existing public APIs, signer paths, dependencies, features, and relay limits remain unchanged.This also:
u64arithmetic for padding and payload sizesnostrchangelog entryNotes to the reviewers
Existing payloads below 65,536 bytes remain byte-for-byte compatible.
Tests cover:
Validation completed locally:
nip44andnip44,os-rngno_std + alloc + nip44git diff --checkThe wasm builds were attempted but could not complete locally because Apple clang lacks the wasm/WASI C backend required by
secp256k1-sys. CI remains responsible for confirming the cross-target build.Processing payloads near the protocol maximum can require several gigabytes of contiguous memory. Applications and relays should continue enforcing appropriate input-size limits before invoking decryption.
Checklist
CHANGELOG.md(if applicable)