Skip to content

NIP46 - update NIP44 calls #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staab merged 3 commits into from
Feb 21, 2024
Merged

NIP46 - update NIP44 calls #983

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c7ae62
update nip44 encrypt/decrypt
monlovesmango Feb 20, 2024
ff39f49
update nip44_get_conversation_key
monlovesmango Feb 20, 2024
0045106
leave nip44_get_conversation_key undefined for now
monlovesmango Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions 46.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,10 @@ Each of the following are methods that the client sends to the remote signer.
| `get_relays` | `[]` | `json_stringified({<relay_url>: {read: <boolean>, write: <boolean>}})` |
| `get_public_key` | `[]` | `<hex-pubkey>` |
| `nip04_encrypt` | `[<third_party_pubkey>, <plaintext_to_encrypt>]` | `<nip04_ciphertext>` |
| `nip04_decrypt` | `[<third_party_pubkey>, <ciphertext_to_decrypt>]` | `<plaintext>` |
| `nip44_conversation_key` | Potential future addition | |
| `nip44_encrypt` | Potential future addition | |
| `nip44_decrypt` | Potential future addition | |
| `nip04_decrypt` | `[<third_party_pubkey>, <nip04_ciphertext_to_decrypt>]` | `<plaintext>` |
| `nip44_encrypt` | `[<third_party_pubkey>, <plaintext_to_encrypt>]` | `<nip44_ciphertext>` |
| `nip44_decrypt` | `[<third_party_pubkey>, <nip44_ciphertext_to_decrypt>]` | `<plaintext>` |
| `nip44_get_conversation_key`| _Potential future addition_ | |
Copy link
Copy Markdown
Member

@alexgleason alexgleason Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove it entirely. There's no point putting future plans in a nip. Either it's defined or it isn't.

Copy link
Copy Markdown
Member

@staab staab Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, #1065


## Response Events `kind:24133`

Expand Down