Skip to content

Use before_action instead of before_filter#37

Open
anilmaurya wants to merge 3 commits into
nosolosoftware:masterfrom
SimplySmartTech:master
Open

Use before_action instead of before_filter#37
anilmaurya wants to merge 3 commits into
nosolosoftware:masterfrom
SimplySmartTech:master

Conversation

@anilmaurya
Copy link
Copy Markdown

Rails 5 do not support before_filter therefore changed before_filter to before_action

@johnnyshields
Copy link
Copy Markdown
Collaborator

please use respond_to?(:before_filter) ? ... to make it Rails version agnostic

@anilmaurya
Copy link
Copy Markdown
Author

@johnnyshields Updated pull request

@bakedbean
Copy link
Copy Markdown

is there a reason this never got merged? I just had to fork to make the same change, seems like a worthwhile thing to get into master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants