Open
Conversation
Owner
|
Thanks, but the CI is red :) |
Author
|
No problem @norkunas - I saw that, and submitted another PR to address it (it was failing due to code quality checks elsewhere in the package ... i've made the changes in that separate PR for you to review and approve). That PR also shows as failing, but i've no idea why (I didn't have any of those issues on my end) or how to fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added Symfony 8 packages to be used as dependencies of this one - this allows anyone whom wants to upgrade to Symfony v8 (which was released in November 2025) to do-so.
I've done a basic test to send a one-signal notification which worked fine, and run php-cs-fixer over it too (which reported a few vars which could be changed to private from protected).