Issue ordered api nested model problems#662
Closed
strutt wants to merge 2 commits intonoirbizarre:masterfrom
strutt:issue-ordered-api-nested-model-problems
Closed
Issue ordered api nested model problems#662strutt wants to merge 2 commits intonoirbizarre:masterfrom strutt:issue-ordered-api-nested-model-problems
strutt wants to merge 2 commits intonoirbizarre:masterfrom
strutt:issue-ordered-api-nested-model-problems
Conversation
The 6 tests added tests shadow the only tests that fail when ordered=True was set in the fixture.
Add check for OrderedModel in Swagger.register_model(self, model) Add check for OrderedModel in ref(model)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi maintainers,
I spent a day figuring this out and generating a PR before noticing it partially duplicates the work for another PR #616.
However, my PR also includes test functions in test_swagger.py that fail pre-patch.
The new tests just create an ordered restplus.Api object for the 6 tests that failed when I set that globally during local testing.
If you accept this PR then you get test coverage too!
Cheers
Ben