fix: array_index_needs_explicit_oob_check must consider flattened size - #13462
Open
asterite wants to merge 2 commits into
Open
fix: array_index_needs_explicit_oob_check must consider flattened size#13462asterite wants to merge 2 commits into
asterite wants to merge 2 commits into
Conversation
Contributor
Changes to circuit sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
The implicit ACIR memory-op check reports the flattened index and size, so composite-element arrays still need the explicit check to report the logical index the user wrote. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Resolved
Resolves https://github.com/noir-lang/noir-claude/issues/1598
Summary of Changes
The check that considers whether an array can't have elements in it was slightly off.
User Documentation
Check one:
PR Checklist
cargo fmton default settings.