Skip to content

Conversation

Asaf-Federman
Copy link
Contributor

@Asaf-Federman Asaf-Federman commented Oct 7, 2025

This pull request skip testing the --max-old-space-size-percentage flag on 32-bit platforms. The flag, which sets the maximum memory size of V8's old memory section as a percentage of available system memory, may cause integer overflow issues on 32-bit systems. The documentation have been updated to clarify its behavior and limitations on 32-bit systems.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 7, 2025
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2025
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.56%. Comparing base (d52cd04) to head (0db4818).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60144      +/-   ##
==========================================
+ Coverage   88.52%   88.56%   +0.03%     
==========================================
  Files         703      703              
  Lines      207997   207997              
  Branches    40024    40014      -10     
==========================================
+ Hits       184134   184207      +73     
+ Misses      15875    15809      -66     
+ Partials     7988     7981       -7     

see 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Asaf-Federman
Copy link
Contributor Author

The tests fail due to flakiness

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants