Rewrite fastutf8stream tests node test #59667
Open
+350
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
@joyeecheung I would need an approval to be able to test it on CI |
jasnell
reviewed
Aug 28, 2025
jasnell
approved these changes
Aug 28, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59667 +/- ##
==========================================
+ Coverage 89.90% 89.91% +0.01%
==========================================
Files 667 667
Lines 196601 196600 -1
Branches 38599 38607 +8
==========================================
+ Hits 176757 176782 +25
+ Misses 12327 12267 -60
- Partials 7517 7551 +34 🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
request-ci
@nodejs/build I'm having a bit of hard time in figuring out how to start the stress test CI |
Rewrite test/parallel/test-fastutf8stream-sync.js and test/parallel/test-fastutf8stream-flush-mocks.js to use node:test with individual test functions and proper stream cleanup. Key changes: - Convert from block-based tests to individual test() functions - Use once() from node:events for proper stream close event handling - Ensure streams emit 'close' event before test completion for Windows compatibility - Fix fsync mocking in flush tests to allow proper stream closure - Each test runs independently with proper resource cleanup
mcollina
force-pushed
the
rewrite-fastutf8stream-tests-node-test
branch
from
13a64e6 to
030514c
Compare
github-actions
bot
removed
the
request-ci
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - test: rewrite fastutf8stream tests to use node:test ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/17357709189 |
github-actions
bot
added
the
request-ci-failed
|
Ok it seems that the stress test CI now started: https://ci.nodejs.org/view/Stress/job/node-stress-single-test/615/. I had to pick |
|
FWIW the original flakes are now gone in the reliability report https://github.com/nodejs/reliability/blob/main/reports/2025-09-01.md |
|
The problem is still there, it really depends on the drive of those virtual machines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59638