Skip to content

Conversation

joyeecheung
Copy link
Member

This adds a new API to allow the bundled script in SEA to query the list of assets.

Refs: nodejs/single-executable#112

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications labels Aug 28, 2025
This adds a new API to allow the bundled script in SEA to query
the list of assets.
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.89%. Comparing base (bcb802c) to head (2e32631).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sea.cc 76.47% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59661      +/-   ##
==========================================
- Coverage   89.91%   89.89%   -0.03%     
==========================================
  Files         667      667              
  Lines      196600   196631      +31     
  Branches    38601    38604       +3     
==========================================
- Hits       176780   176766      -14     
- Misses      12269    12319      +50     
+ Partials     7551     7546       -5     
Files with missing lines Coverage Δ
lib/sea.js 98.88% <100.00%> (+0.20%) ⬆️
src/node_sea.cc 86.20% <76.47%> (-0.31%) ⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants