src,sqlite: refactor value conversion

[geeksilva97]

This PR refactors SatetmentSync::All and StatementSyncIterator::Next methods to reduce complexity.

This will make it a lot easier to move forward with the implementation of the async api for node:sqlite

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[codecov]

Codecov Report

❌ Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.87%. Comparing base (bcb802c) to head (ae60602).
⚠️ Report is 23 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	86.95%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #59659      +/-   ##
==========================================
- Coverage   89.91%   89.87%   -0.04%     
==========================================
  Files         667      667              
  Lines      196600   196777     +177     
  Branches    38601    38622      +21     
==========================================
+ Hits       176780   176863      +83     
- Misses      12269    12361      +92     
- Partials     7551     7553       +2     

Files with missing lines	Coverage Δ
src/node_sqlite.h	83.67% <ø> (ø)
src/node_sqlite.cc	81.28% <86.95%> (+0.17%)	⬆️

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Renegade334]

Looking good. Is it worth doing the same with the column keys extraction? Obviously it wouldn't deduplicate anything now, but presumably would do if an async API were added?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68973/

[geeksilva97]

Looking good. Is it worth doing the same with the column keys extraction? Obviously it wouldn't deduplicate anything now, but presumably would do if an async API were added?

Your assumption is correct. I can address this in the async api PR

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/59659
✔  Done loading data for nodejs/node/pull/59659
----------------------------------- PR info ------------------------------------
Title      src,sqlite: refactor value conversion (#59659)
Author     Edy Silva <[email protected]> (@geeksilva97)
Branch     geeksilva97:refactor-sqlite-value-conversion -> nodejs:main
Labels     c++, author ready, commit-queue-squash, sqlite
Commits    2
 - src,sqlite: refactor value conversion
 - src: use Maybe instead of std::optional
Committers 1
 - Edy Silva <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/59659
Reviewed-By: Anna Henningsen <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59659
Reviewed-By: Anna Henningsen <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 28 Aug 2025 03:53:32 GMT
   ✔  Approvals: 1
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/59659#pullrequestreview-3171578413
   ✘  This PR needs to wait 83 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-08-31T14:06:05Z: https://ci.nodejs.org/job/node-test-pull-request/68973/
- Querying data for job/node-test-pull-request/68973/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/17359749713