-
-
Notifications
You must be signed in to change notification settings - Fork 32.9k
lib: revert to using default derived class constructors #59650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
Renegade334:lib-use-default-constructors
Aug 30, 2025
Merged
lib: revert to using default derived class constructors #59650
nodejs-github-bot
merged 1 commit into
nodejs:main
from
Renegade334:lib-use-default-constructors
Aug 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
mcollina
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
should this have some do-not-backport labels?
targos
approved these changes
Aug 27, 2025
aduh95
approved these changes
Aug 27, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59650 +/- ##
==========================================
+ Coverage 89.89% 89.91% +0.01%
==========================================
Files 667 667
Lines 196579 196552 -27
Branches 38592 38586 -6
==========================================
+ Hits 176710 176725 +15
+ Misses 12320 12286 -34
+ Partials 7549 7541 -8
🚀 New features to boost your workflow:
|
Landed in 196f546 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ES2021 altered the behaviour of default constructors for derived classes, such that constructor calls no longer use array spreading when passing arguments to the parent constructor.
The following used to fail, but passes as of v22.0.0:
Previously, internal derived classes were given manually-defined "pass-through" constructors in order to avoid exposure to prototype pollution. These are no longer required, and can be safely removed.
cc: @aduh95