-
-
Notifications
You must be signed in to change notification settings - Fork 32.9k
crypto: add KMAC Web Cryptography algorithms #59647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
panva
wants to merge
4
commits into
nodejs:main
Choose a base branch
from
panva:webcrypto-kmac
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
3e44147
to
5e3754e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59647 +/- ##
==========================================
+ Coverage 89.86% 89.88% +0.02%
==========================================
Files 667 669 +2
Lines 196489 196837 +348
Branches 38586 38658 +72
==========================================
+ Hits 176571 176936 +365
+ Misses 12378 12354 -24
- Partials 7540 7547 +7
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
crypto
Issues and PRs related to the crypto subsystem.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
experimental
Issues and PRs related to experimental features.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
review wanted
PRs that need reviews.
semver-minor
PRs that contain new features and should be released in the next minor version.
webcrypto
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds KMAC1 to SubtleCrypto as per https://wicg.github.io/webcrypto-modern-algos/#kmac
Footnotes
https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-185.pdf ↩