Skip to content

Conversation

panva
Copy link
Member

@panva panva commented Aug 27, 2025

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/web-infra

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 27, 2025
@panva panva added crypto Issues and PRs related to the crypto subsystem. semver-minor PRs that contain new features and should be released in the next minor version. experimental Issues and PRs related to experimental features. webcrypto dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Aug 27, 2025
@panva panva force-pushed the webcrypto-kmac branch 4 times, most recently from 3e44147 to 5e3754e Compare August 27, 2025 14:36
@panva panva requested review from jasnell and tniessen August 27, 2025 15:23
@nodejs-github-bot

This comment was marked as outdated.

Copy link

codecov bot commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.88%. Comparing base (ec8c73d) to head (e73b1c1).
⚠️ Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
src/crypto/crypto_kmac.cc 55.65% 29 Missing and 22 partials ⚠️
lib/internal/crypto/mac.js 94.66% 4 Missing ⚠️
src/crypto/crypto_kmac.h 33.33% 2 Missing ⚠️
lib/internal/crypto/webidl.js 98.38% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59647      +/-   ##
==========================================
+ Coverage   89.86%   89.88%   +0.02%     
==========================================
  Files         667      669       +2     
  Lines      196489   196837     +348     
  Branches    38586    38658      +72     
==========================================
+ Hits       176571   176936     +365     
+ Misses      12378    12354      -24     
- Partials     7540     7547       +7     
Files with missing lines Coverage Δ
lib/internal/crypto/keys.js 95.23% <100.00%> (+0.01%) ⬆️
lib/internal/crypto/util.js 95.43% <100.00%> (+0.13%) ⬆️
lib/internal/crypto/webcrypto.js 96.30% <100.00%> (+0.06%) ⬆️
src/node_crypto.cc 81.81% <ø> (ø)
lib/internal/crypto/webidl.js 98.76% <98.38%> (-0.09%) ⬇️
src/crypto/crypto_kmac.h 33.33% <33.33%> (ø)
lib/internal/crypto/mac.js 92.50% <94.66%> (+0.50%) ⬆️
src/crypto/crypto_kmac.cc 55.65% <55.65%> (ø)

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@panva panva added the review wanted PRs that need reviews. label Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. experimental Issues and PRs related to experimental features. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. review wanted PRs that need reviews. semver-minor PRs that contain new features and should be released in the next minor version. webcrypto
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants