-
-
Notifications
You must be signed in to change notification settings - Fork 32.9k
src: migrate WriteOneByte to WriteOneByteV2 #59634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59634 +/- ##
==========================================
+ Coverage 89.85% 89.90% +0.04%
==========================================
Files 667 667
Lines 196260 196606 +346
Branches 38559 38595 +36
==========================================
+ Hits 176341 176750 +409
+ Misses 12368 12313 -55
+ Partials 7551 7543 -8
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Looks like some tests crash because of this changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cd2810c
to
95f4f0d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
95f4f0d
to
2249366
Compare
Updated call sites that expect loose convertion to onte bytes, and fixed debug checks. |
Landed in 5af0355 |
v8::String::WriteOneByteV2
now defaults toNO_NULL_TERMINATION
. Call sites expect null termination should set flagString::WriteFlags::kNullTerminate
.String::REPLACE_INVALID_UTF8
is a no-op inWriteOneByteV2
.Fixes: #59555