Skip to content

Conversation

F3lixTheCat
Copy link
Contributor

We should check end for nullptr in one of the if-else branches in ImplementationVisitor::Visit

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Aug 26, 2025
@F3lixTheCat F3lixTheCat changed the title src: added nullptr for 'end' in /deps/v8/src/torque/implementation-visitor.cc src: added nullptr for 'end' in ImplementationVisitor::Visit Aug 26, 2025
@F3lixTheCat F3lixTheCat changed the title src: added nullptr for 'end' in ImplementationVisitor::Visit src: added nullptr check for 'end' in ImplementationVisitor::Visit Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants