Skip to content

benchmark: reflect current OpenSSL in crypto key benchmarks #59459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

benchmark: reflect current OpenSSL in crypto key benchmarks #59459

wants to merge 1 commit into from
+18 −6

Conversation

panva
Copy link
Member

@panva panva commented Aug 13, 2025

updates the crypto benchmarks so that they can be executed on OpenSSL < 3.5 and don't always run non 3.5 jobs in CI into flake status.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. crypto Issues and PRs related to the crypto subsystem. labels Aug 13, 2025
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 13, 2025
H4ad
H4ad reviewed Aug 13, 2025
View reviewed changes
Copy link
Member

@H4ad H4ad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a link for something that explains more about this change?

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H4ad H4ad H4ad left review comments

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. commit-queue Add this label to land a pull request using GitHub Actions. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@panva @nodejs-github-bot @lpinca @tniessen @richardlau @H4ad @RafaelGSS