Skip to content

[v22.x backport] expose setupInstance method on WASI class #59255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: v22.x-staging
Choose a base branch
from
Open

[v22.x backport] expose setupInstance method on WASI class #59255

wants to merge 2 commits into from
+261 −24

Conversation

toyobayashi
Copy link
Contributor

Backport #57214

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/wasi
  • @nodejs/web-infra

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. wasi Issues and PRs related to the WebAssembly System Interface. labels Jul 28, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68260/

@toyobayashi
Copy link
Contributor Author

@aduh95 Sorry I have no idea why this error occurred and I can't debug under win2016-COMPILED_BY-vs2022-x86 environment. It seems WASI itself has bug in this environment. The original PR just added a method to WASI class and added multithreaded initialization process to WASI test (added importObject.wasi['thread-spawn']) theoretically there are no breaking changes to the tests.

@aduh95 aduh95 force-pushed the v22.x-staging branch 2 times, most recently from 6bb153b to f64f5df Compare August 26, 2025 09:22
@aduh95
Copy link
Contributor

aduh95 commented Oct 7, 2025

I don't think skipping is the right approach, if this is causing a regression, we should either not backport it, or fix the regression first

@guybedford

This comment was marked as outdated.

Sign in to view
@guybedford
Copy link
Contributor

Sorry misread the diff - @aduh95 it seems you are correct to flag this.

@toyobayashi toyobayashi force-pushed the backport-wasi-finalizebindings-to-v22.x branch from 8508643 to f6129a5 Compare October 8, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@flakey5 flakey5 flakey5 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. wasi Issues and PRs related to the WebAssembly System Interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@toyobayashi @nodejs-github-bot @aduh95 @guybedford @flakey5