Skip to content
Merged
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions doc/contributing/collaborator-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,13 @@ requirements. If a pull request meets all requirements except the

Collaborators can object to a pull request by using the "Request
Changes" GitHub feature. Dissent comments alone don't constitute an
objection. Any pull request objection must include a clear reason for that
objection, and the objector must remain responsive for further discussion
towards consensus about the direction of the pull request. Where possible,
provide a set of actionable steps alongside the objection.
objection, nor do dissenting comments made in any associated issue.
A blocking objection to a change must be made in the pull request that
specifically proposes that change. Any pull request objection must include
a clear reason for that objection, and the objector must remain responsive
for further discussion towards consensus about the direction of the pull
request. Where possible, provide a set of actionable steps alongside the
objection.

If the objection is not clear to others, another collaborator can ask an
objecting collaborator to explain their objection or to provide actionable
Expand All @@ -168,7 +171,24 @@ dismiss the objection.
Pull requests with outstanding objections must remain open until all
objections are satisfied. If reaching consensus is not possible, a
collaborator can escalate the issue to the TSC by pinging `@nodejs/tsc` and
adding the `tsc-agenda` label to the issue.
adding the `tsc-agenda` label to the issue. The change cannot proceed without
either reaching consensus or a TSC decision to dismiss the objection(s). If the
TSC does choose to dismiss any objections, a clear explanation of the reasoning
or a link to the public vote must be given in the pull request before it lands.

All Collaborator objections are considered equal. There is no greater weight given to
objections from TSC members than from any other Collaborator.

Mistakes do happen from time-to-time. If a pull request is merged with an
outstanding objection, corrective action must be taken. Any Collaborator
can open a pull request that either reverts the change or makes an additional
follow-up change that addresses the objection. While an automatic or immediate
revert is not always necessary or ideal, such corrections are typically subject to
fast-tracking, but are not required to be fast-tracked. There are
times in which taking a slower path may be preferable.

Collaborators objecting to a pull request can best ensure their objections
are addressed by remaining actively engaged and responsive in the discussion.

#### Helpful resources

Expand Down
Loading