sqlite,doc: add setReturnArrays missing docs #59074
Open
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
doc
geeksilva97
commented
Jul 15, 2025
geeksilva97
requested review from
RafaelGSS,
marco-ippolito,
gurgunday and
cjihrig
RafaelGSS
added
dont-land-on-v20.x
I think so. When I look into the v22.x branch, I can see the code there https://github.com/nodejs/node/blob/v22.x/src/node_sqlite.cc#L2313 |
geeksilva97
removed
the
dont-land-on-v22.x
geeksilva97
force-pushed
the
add-missing-sqlite-documentation
branch
from
4782318 to
0438ffb
Compare
geeksilva97
commented
Jul 15, 2025
| ### `statement.setReturnArrays(enabled)` | ||
|
|
||
| <!-- YAML | ||
| added: 24.0.0 |
There was a problem hiding this comment.
Set to 24.0.0 based on #57609
|
We will want this to land on v22. Should I open the backport now? |
|
Link is complaining about the hardcoded version, but I think that's expected and acceptable in this case. |
Yes, please. |
atlowChemi
approved these changes
Jul 15, 2025
Okay, so I will land this, and open the backport. |
lpinca
approved these changes
Jul 15, 2025
geeksilva97
added
commit-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
StatementSync.prototype.setReturnArrayswas introduced a few months ago but its documentation was not added.This PR adds such a documentation.