-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
feat: support ${pid}
placeholder in --cpu-prof-name
#59072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
I didn’t modify the affected section in cli.md, but the build fails with a link not found error. It seems to be an issue related to the documentation build tooling or other files, not my changes. |
Please run |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59072 +/- ##
==========================================
+ Coverage 90.06% 90.07% +0.01%
==========================================
Files 645 645
Lines 189130 189144 +14
Branches 37094 37095 +1
==========================================
+ Hits 170339 170375 +36
+ Misses 11511 11476 -35
- Partials 7280 7293 +13
🚀 New features to boost your workflow:
|
This patch adds support for runtime substitution of the ${pid} placeholder
in the --cpu-prof-name option. This is helpful when using cluster/forked
processes to avoid profile file name collisions.
Previously, patterns like ${pid} were not substituted. Now, ${pid} will
be replaced with the current process ID.
Example:
node --cpu-prof --cpu-prof-name 'CPU.${pid}.cpuprofile' index.js
Generates: CPU.12345.cpuprofile
Also updated the CLI documentation accordingly.
Fixes: #57418