crypto: avoid copying buffers to UTF-8 strings in crypto.hash()

[Renegade334]

Fixes: #59057

Testing in the wild confirms this to fix the associated downstream issue. Not sure a unit test is feasible.

cc: @nodejs/releasers – given the impact on the ecosystem, this would ideally be a candidate for a patch release.

[nodejs-github-bot]

Review requested:

• @nodejs/crypto

[panva]

This likely will have to wait for after the announced security releases.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (049664b) to head (2a23cf2).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #59067   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files         645      645           
  Lines      189130   189130           
  Branches    37094    37085    -9     
=======================================
+ Hits       170339   170349   +10     
+ Misses      11511    11507    -4     
+ Partials     7280     7274    -6     

Files with missing lines	Coverage Δ
src/crypto/crypto_hash.cc	70.65% <100.00%> (+0.29%)	⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[joyeecheung]

LGTM. On a side note according to #59057 this primarily happens on Linux so is likely attributed to fragmentation in glibc's malloc implementation (#21973), and now it seems to affect sync calls with a lot of buffers as well, which is somewhat concerning as the performance issue can lead to OOM..