Skip to content

src: call unmask after install signal handler #59059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theanarkh
Copy link
Contributor

Call unmask after installing signal handler to ensure the signal is caught.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/inspector

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Jul 14, 2025
@theanarkh theanarkh force-pushed the unmask_after_install_handler branch from 25f4495 to a6c462c Compare July 14, 2025 00:41
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.05%. Comparing base (049664b) to head (a6c462c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/inspector_agent.cc 33.33% 1 Missing and 1 partial ⚠️
src/node_watchdog.cc 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59059      +/-   ##
==========================================
- Coverage   90.06%   90.05%   -0.01%     
==========================================
  Files         645      645              
  Lines      189130   189132       +2     
  Branches    37094    37095       +1     
==========================================
- Hits       170339   170331       -8     
+ Misses      11511    11506       -5     
- Partials     7280     7295      +15     
Files with missing lines Coverage Δ
src/node_watchdog.cc 71.94% <50.00%> (+0.12%) ⬆️
src/inspector_agent.cc 79.94% <33.33%> (-0.11%) ⬇️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants