src: fix broken fast callback signatures #59055
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
Renegade334
force-pushed
the
fix-histogram-fast-callbacks
branch
from
d230f2e to
7f27665
Compare
Renegade334
commented
Jul 13, 2025
Comment on lines
-190
to
-194
| if (value < 1) { | ||
| HandleScope scope(options.isolate); | ||
| THROW_ERR_OUT_OF_RANGE(options.isolate, "value is out of range"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
value is validated in the JS layer, so a debug check should be fine here.
Renegade334
force-pushed
the
fix-histogram-fast-callbacks
branch
from
7f27665 to
93048b8
Compare
Renegade334
force-pushed
the
fix-histogram-fast-callbacks
branch
from
93048b8 to
9926389
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59055 +/- ##
==========================================
+ Coverage 90.06% 90.08% +0.01%
==========================================
Files 645 645
Lines 189130 189126 -4
Branches 37094 37090 -4
==========================================
+ Hits 170339 170372 +33
+ Misses 11511 11466 -45
- Partials 7280 7288 +8
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #54408, the various fast callbacks that were edited by that PR have broken signatures and have not been invoked. (The changed signatures would only have been valid if the receiver were prepended to the function arguments wherever those bindings were called from JS, which isn't the case.)
There was no debug tracking of these callbacks, so this went unnoticed at the time.
This change fixes the broken signatures and adds debug testing to validate the fast paths.
This effectively reverts the remaining source changes from #54408 that were not already covered by #58054.