-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
dgram: improve get-send-queue-info performance #59054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59054 +/- ##
==========================================
- Coverage 90.07% 90.05% -0.03%
==========================================
Files 641 645 +4
Lines 188998 189150 +152
Branches 37069 37093 +24
==========================================
+ Hits 170246 170345 +99
- Misses 11462 11521 +59
+ Partials 7290 7284 -6
🚀 New features to boost your workflow:
|
bench.start(); | ||
|
||
if (method === 'size') { | ||
for (let i = 0; i < n; ++i) server.getSendQueueSize(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think at some point this will be JIT-eliminated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that getSendQueueSize()
will not be JIT eliminated because it still calls into libuv. Im using size
and count
now to accumulate the results in order to make that explicit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevermind, I was looking to HEAD.
Improve
dgram
getSendQueueSize
andgetSendQueueCount
performance by using V8 fast API.Local benchmark: