Skip to content

build: bump minimum Clang version to 19 #59048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

build: bump minimum Clang version to 19 #59048

wants to merge 3 commits into from
+64 −13

Conversation

targos
Copy link
Member

@targos targos commented Jul 13, 2025

This is now required by V8.

Refs: nodejs/node-v8#302

@targos targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 13, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. labels Jul 13, 2025
@targos
Copy link
Member Author

targos commented Jul 13, 2025

I checked Visual Studio 2022 on my computer and it has Clang 19.1.5.
With #58069, Xcode will have LLVM 19.1.4.

@targos
Copy link
Member Author

targos commented Jul 13, 2025

/cc @nodejs/build @nodejs/tsc

targos and others added 2 commits July 13, 2025 13:36
@targos
build: bump minimum Clang version to 19
afd92fa 
This is now required by V8.

Refs: nodejs/node-v8#302
@legendecas @targos
deps: V8: cherry-pick 493cb53691be
ce86920 
Original commit message:

    [include] suppress clang cast-function-type-mismatch warning on SetWeak

    Suppress clang warning cast-function-type-mismatch in embedder calls
    to `SetWeak`.

    Change-Id: I6c4eda1b932199a2ea4947fe851ffdf2ae04ad73
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6689209
    Reviewed-by: Camillo Bruni <[email protected]>
    Commit-Queue: Chengzhong Wu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#101186}

Refs: v8/v8@493cb53
@targos targos added the blocked PRs that are blocked by other issues or PRs. label Jul 13, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.51%. Comparing base (049664b) to head (ce86920).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59048      +/-   ##
==========================================
- Coverage   90.06%   89.51%   -0.56%     
==========================================
  Files         645      645              
  Lines      189130   189128       -2     
  Branches    37094    36807     -287     
==========================================
- Hits       170339   169295    -1044     
- Misses      11511    12483     +972     
- Partials     7280     7350      +70

see 97 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

richardlau
richardlau reviewed Jul 14, 2025
View reviewed changes
mcollina
mcollina approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@richardlau richardlau richardlau approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
blocked PRs that are blocked by other issues or PRs. build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@targos @nodejs-github-bot @mcollina @lpinca @anonrig @richardlau @RafaelGSS @legendecas