-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
buffer: cache Environment::GetCurrent to avoid repeated calls #59043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59043 +/- ##
=======================================
Coverage 90.06% 90.07%
=======================================
Files 645 645
Lines 189130 189131 +1
Branches 37094 37089 -5
=======================================
+ Hits 170339 170353 +14
+ Misses 11511 11480 -31
- Partials 7280 7298 +18
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the commit message should mention buffer (or the specific buffer API this change is affecting) somewhere 🤔
As you said, I think it would be correct to mention the buffer in the commit message |
3dcaaa3
to
f444c8e
Compare
cache Environment::GetCurrent to avoid repeated calls