Skip to content

lib: add trace-sigint APIs #59040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theanarkh
Copy link
Contributor

@theanarkh theanarkh commented Jul 12, 2025

trace-sigint command line option is useful for debugging the busy code, expose it as API for using at runtime, such as APM SDK.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@theanarkh theanarkh marked this pull request as ready for review July 12, 2025 08:44
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Jul 12, 2025
@theanarkh theanarkh force-pushed the make_trace_sigint_programmable branch 3 times, most recently from 04cd016 to d3eadac Compare July 12, 2025 18:03
@theanarkh theanarkh force-pushed the make_trace_sigint_programmable branch from d3eadac to e8583be Compare July 12, 2025 18:47
Copy link

codecov bot commented Jul 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.05%. Comparing base (049664b) to head (e8583be).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59040      +/-   ##
==========================================
- Coverage   90.06%   90.05%   -0.01%     
==========================================
  Files         645      645              
  Lines      189130   189142      +12     
  Branches    37094    37097       +3     
==========================================
  Hits       170339   170339              
+ Misses      11511    11508       -3     
- Partials     7280     7295      +15     
Files with missing lines Coverage Δ
lib/internal/process/pre_execution.js 90.90% <100.00%> (+0.16%) ⬆️
lib/internal/watchdog.js 89.65% <ø> (+15.07%) ⬆️

... and 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants