node-api: reword "implementation in an alternative VM" as implementable #59036
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
vmoroz
approved these changes
Jul 11, 2025
bnoordhuis
reviewed
Jul 11, 2025
| @@ -37,7 +37,7 @@ please follow these principles and guidelines: | |||
|
|
|||
| 2. **Review and approval** | |||
| * A new API addition **must** be signed off by at least two Node-API team members. | |||
| * **Should** be implemented in at least one other VM implementation of Node.js. | |||
| * **Should** be implementable in at least one other VM implementation of Node.js. | |||
There was a problem hiding this comment.
"implementable" is very vague, even weasel wordy. Everything is implementable given enough time and effort.
Reductio ad ad absurdum: parsing and executing Python code isn't implemented in V8 but given a ground-up rewrite sure is implementable. Surely that's not what you mean though.
"Can be implemented in terms of available VM APIs" maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should relieve contributors from forced to implement the new API in another VM. But the requirement should remain proving the new API to be implementable in another VM, and not specific to V8, allowing node-api to maintain ABI-stability.
Fixes: #58852