Skip to content

Adding missing internal codes #59022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

miguelmarcondesf
Copy link
Contributor

Adding some missing codes mentioned on errors but not available on internal/errors, I followed node_errors for error type and message

@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. labels Jul 10, 2025
@aduh95
Copy link
Contributor

aduh95 commented Jul 10, 2025

I'm not sure we need this, if those are not used on JS side, then adding them is pure overhead, no?

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (b7db89f) to head (f3f6f7f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59022      +/-   ##
==========================================
- Coverage   90.08%   90.06%   -0.02%     
==========================================
  Files         645      645              
  Lines      189148   189171      +23     
  Branches    37097    37095       -2     
==========================================
- Hits       170395   170385      -10     
- Misses      11470    11510      +40     
+ Partials     7283     7276       -7     
Files with missing lines Coverage Δ
lib/internal/errors.js 97.51% <100.00%> (+0.01%) ⬆️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@miguelmarcondesf
Copy link
Contributor Author

Closing this and adding only the needed ERR_CONSTRUCT_CALL_REQUIRED on the linked PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants