-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
test: skip tests that cause timeouts on IBM i #59014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59014 +/- ##
========================================
Coverage 90.07% 90.08%
========================================
Files 641 645 +4
Lines 188998 189128 +130
Branches 37069 37094 +25
========================================
+ Hits 170246 170370 +124
- Misses 11462 11464 +2
- Partials 7290 7294 +4 🚀 New features to boost your workflow:
|
So unfortunately the build still fails because the build detects that
|
Thanks for pointing that out. Since that behavior is happening do you think we should skip the tests (until we resolve the underlying issue) so that they don't spawn the child processes? |
Yes, let's go with skipping until we figure out why they're timing out. |
I missed adding a couple of test cases in my previous PR: nodejs#58583 We have to skip these instead of marking as flaky because the build still fails because the build detects that node process are left behind after the tests, presumably because tests that spawn child processes are being timed out and only the parent process is killed off, leaving the child processes behind. see: nodejs#59014 (comment) The tests being skipped are: - parallel.test-http-proxy-fetch - parallel.test-https-proxy-fetch - benchmark.test-benchmark-websocket - parallel.test-inspector-network-fetch - parallel.test-inspector-network-content-type - es-module.test-wasm-web-api - parallel.test-fetch - parallel.test-without-async-context-frame - report.test-report-exclude-network
I missed marking a couple of test cases flaky in my previous PR: nodejs#58583 tests missed were: - parallel.test-inspector-network-content-type - benchmark.test-benchmark-websocket After marking the above flaky I re-ran a test build and noticed the build still failed. Unfortuantely the build still fails because the build detects that node process are left behind after the tests, presumably because tests that spawn child processes are being timed out and only the parent process is killed off, leaving the child processes behind. see: nodejs#59014 (comment) We've decided to skip these tests until the underlying issue is resolved. The tests being skipped are: - parallel.test-http-proxy-fetch - parallel.test-https-proxy-fetch - benchmark.test-benchmark-websocket - parallel.test-inspector-network-fetch - parallel.test-inspector-network-content-type - es-module.test-wasm-web-api - parallel.test-fetch - parallel.test-without-async-context-frame - report.test-report-exclude-network
b2cf9dd
to
8902afc
Compare
I missed marking a couple of test cases flaky in my previous PR: nodejs#58583 tests missed were: - parallel.test-inspector-network-content-type - benchmark.test-benchmark-websocket After marking the above flaky I re-ran a test build and noticed the build still failed. Unfortuantely the build still fails because the build detects that node process are left behind after the tests, presumably because tests that spawn child processes are being timed out and only the parent process is killed off, leaving the child processes behind. see: nodejs#59014 (comment) We've decided to skip these tests until the underlying issue is resolved. The tests being skipped are: - parallel.test-http-proxy-fetch - parallel.test-https-proxy-fetch - benchmark.test-benchmark-websocket - parallel.test-inspector-network-fetch - parallel.test-inspector-network-content-type - es-module.test-wasm-web-api - parallel.test-fetch - parallel.test-without-async-context-frame - report.test-report-exclude-network
8902afc
to
db5c570
Compare
Updated test build: https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi74-ppc64/2005/console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I missed marking a couple of test cases flaky in my previous PR:
#58583
tests missed were:
After marking the above flaky I re-ran a test build and noticed
the build still failed.
Unfortuantely the build still fails because the build detects that
node process are left behind after the tests, presumably because tests
that spawn child processes are being timed out and only the parent
process is killed off, leaving the child processes behind.
see: #59014 (comment)
We've decided to skip these tests until the underlying issue is
resolved.
The tests being skipped are: