-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
doc: inject sidebar active link scroll into view script #59007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't add JavaScript unless it's absolutely needed.
If it is, this should added to the assets, rather than directly to the HTML
a257f95
to
defccdf
Compare
Thanks for the tip, it would be nice to add automatic scrolling of active sidebar links into the view area. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please lint, fix the casing, and add comments
08d3e30
to
09348d4
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, CI is failing because the first commit starts with fix
, it should be doc
09348d4
to
6643d19
Compare
I have modified the commit information. |
When searching for the API in the Quick Flower Cutting module, each time you switch to a different module, the content in the sidebar scrolls to the top, and the currently active link is not immediately visible.