feat: add support for 'electron' condition in conditional exports

[Momena-akhtar]

Description

This PR adds support for resolving "electron" condition in both ESM and CommonJS module resolution, based on process.versions.electron. Useful for runtime-specific exports for Electron apps.

Resolves electron/electron#47670

[nodejs-github-bot]

Review requested:

• @nodejs/loaders

[ljharb]

How does adding this string to conditions alter resolution for non-electron users?

[ShogunPanda]

Hi!
I understand the need for this but I don't like the ad-hoc approach.
Could you rewrite in a way that is generic? Such as an API that registers custom functions to trigger conditions.

Something like (totally made up API, just giving an hint):

$ node --import conditions-register.js index.js

And in conditions-register.js:

import { registerCondition } from 'node:module'

registerCondition((nmPath, request, conditions) {
  if (process.versions?.electron && conditions?.add) {
    conditions.add('electron');
  }
})

[Momena-akhtar]

Hi! I understand the need for this but I don't like the ad-hoc approach. Could you rewrite in a way that is generic? Such as an API that registers custom functions to trigger conditions.

Something like (totally made up API, just giving an hint):

$ node --import conditions-register.js index.js

And in conditions-register.js:

import { registerCondition } from 'node:module'

registerCondition((nmPath, request, conditions) {
  if (process.versions?.electron && conditions?.add) {
    conditions.add('electron');
  }
})

Will definitely give it a try and open the PR!

[himself65]

I personally really don't like to have such downstream (electron) code into upstream (node)